Add conditional return type for Clients.matchAll #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Manduro
force-pushed
the
clients-match-all
branch
from
4f0e0f0 to
c661c23
Compare
When specifically querying for clients of type window, return the specific WindowClient type.
Manduro
force-pushed
the
clients-match-all
branch
from
c661c23 to
5d63f61
Compare
sandersn
reviewed
Dec 11, 2020
Use narrower `extends` test in conditional type.
sandersn
reviewed
Dec 11, 2020
Add missed source JSON update
orta
approved these changes
Dec 11, 2020
sandersn
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifically querying for clients of type
window, return the specificWindowClienttype instead of the genericClienttype.