fix(40454): allow IntersectionObserverInit.root to accept type Docume…

[troyt-42]

…nt and update IntersectionObserver.root to be of type Node

Fix microsoft/TypeScript#40454

[ghost]

All CLA requirements met.

[saschanaz]

The right way to do this is updating idlSource.json to point https://w3c.github.io/IntersectionObserver/ and running npm run fetch-idl "Intersection Observer" && npm run build && npm run baseline-accept, so that we can keep syncing with the upstream changes.

[troyt-42]

@saschanaz thanks for the comment! I tried that approach, but it seems https://w3c.github.io/IntersectionObserver/ changed all void type to undefined type

which makes the script throws

Error: Unknown DOM type: undefined
    at convertDomTypeToTsTypeSimple (/Users/troytao/TSJS-lib-generator/lib/emitter.js:301:15)
    at convertDomTypeToTsTypeWorker (/Users/troytao/TSJS-lib-generator/lib/emitter.js:239:28)
    at convertDomTypeToTsType (/Users/troytao/TSJS-lib-generator/lib/emitter.js:233:22)
    at emitSignature (/Users/troytao/TSJS-lib-generator/lib/emitter.js:598:26)
    at /Users/troytao/TSJS-lib-generator/lib/emitter.js:610:45
    at Array.forEach (<anonymous>)
    at emitSignatures (/Users/troytao/TSJS-lib-generator/lib/emitter.js:610:30)
    at emitMethod (/Users/troytao/TSJS-lib-generator/lib/emitter.js:590:13)
    at /Users/troytao/TSJS-lib-generator/lib/emitter.js:620:31
    at Array.forEach (<anonymous>)

Is it ok if I add a ['undefined', 'void'] to baseTypeConversionMap in emitter.ts to fix this ?

[saschanaz]

Is it ok if I add a ['undefined', 'void'] to baseTypeConversionMap in emitter.ts to fix this ?

Gread find! Yes, that will fix it.

[troyt-42]

@saschanaz updated!

[saschanaz]

LGTM 👍

[troyt-42]

@sandersn poke you for merging this PR ...

[saschanaz]

BTW, #920 did this in another way so we don't need this anymore. Sorry, but still was a good work!

[saschanaz]

Could you run npm run fetch-idl "Intersection Observer" && npm run build && npm run baseline-accept once again? I think that will fix the attribute type also to Element | Document | null.

[troyt-42]

@saschanaz thanks for notifying! I just rebased the PR, removed the change in helpers.ts and ran npm run fetch-idl "Intersection Observer" && npm run build && npm run baseline-accept.

[saschanaz]

The TypeScript team will review and merge this when the "review time" comes, so please wait until that happens 🙏