Skip to content

Remove redundant override-types #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5057,7 +5057,6 @@ interface ElementEventMap {

/** Element is the most general base class from which all objects in a Document inherit. It only has methods and properties common to all kinds of elements. More specific classes inherit from Element. */
interface Element extends Node, Animatable, ChildNode, InnerHTML, NonDocumentTypeChildNode, ParentNode, Slottable {
readonly assignedSlot: HTMLSlotElement | null;
readonly attributes: NamedNodeMap;
/**
* Allows for manipulation of element's class content attribute as a set of whitespace-separated tokens through a DOMTokenList object.
Expand Down Expand Up @@ -8635,7 +8634,6 @@ declare var HTMLTableElement: {
};

interface HTMLTableHeaderCellElement extends HTMLTableCellElement {
scope: string;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLTableHeaderCellElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLTableHeaderCellElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -11030,7 +11028,6 @@ declare var NodeList: {
};

interface NodeListOf<TNode extends Node> extends NodeList {
length: number;
item(index: number): TNode;
/**
* Performs the specified action for each node in an list.
Expand Down
115 changes: 32 additions & 83 deletions inputfiles/addedTypes.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@
"name": "activeElement",
"read-only": 1,
"override-type": "Element | null"
},
"styleSheets": {
"name": "styleSheets",
"read-only": 1,
"override-type": "StyleSheetList"
}
}
}
Expand Down Expand Up @@ -210,17 +205,6 @@
}
]
}
},
"HTMLHyperlinkElementUtils": {
"name": "HTMLHyperlinkElementUtils",
"properties": {
"property": {
"origin": {
"name": "origin",
"override-type": "string"
}
}
}
}
}
},
Expand Down Expand Up @@ -266,27 +250,27 @@
"in1": {
"name": "in1",
"read-only": 1,
"override-type": "SVGAnimatedString"
"type": "SVGAnimatedString"
},
"dx": {
"name": "dx",
"read-only": 1,
"override-type": "SVGAnimatedNumber"
"type": "SVGAnimatedNumber"
},
"dy": {
"name": "dy",
"read-only": 1,
"override-type": "SVGAnimatedNumber"
"type": "SVGAnimatedNumber"
},
"stdDeviationX": {
"name": "stdDeviationX",
"read-only": 1,
"override-type": "SVGAnimatedNumber"
"type": "SVGAnimatedNumber"
},
"stdDeviationY": {
"name": "stdDeviationY",
"read-only": 1,
"override-type": "SVGAnimatedNumber"
"type": "SVGAnimatedNumber"
}
}
},
Expand Down Expand Up @@ -493,14 +477,6 @@
],
"exposed": "Window",
"extends": "NodeList",
"properties": {
"property": {
"length": {
"name": "length",
"override-type": "number"
}
}
},
"methods": {
"method": {
"item": {
Expand Down Expand Up @@ -653,19 +629,10 @@
},
"properties": {
"property": {
"assignedSlot": {
"name": "assignedSlot",
"read-only": 1,
"override-type": "HTMLSlotElement | null"
},
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
},
"slot": {
"name": "slot",
"override-type": "string"
"type": "Document"
}
}
}
Expand Down Expand Up @@ -719,12 +686,13 @@
"pointerEnabled": {
"name": "pointerEnabled",
"read-only": 1,
"override-type": "boolean"
"type": "boolean"
},
"doNotTrack": {
"name": "doNotTrack",
"read-only": 1,
"override-type": "string | null"
"nullable": 1,
"type": "DOMString"
}
}
}
Expand All @@ -749,17 +717,6 @@
}
]
},
"HTMLTextAreaElement": {
"name": "HTMLTextAreaElement",
"properties": {
"property": {
"minLength": {
"name": "minLength",
"override-type": "number"
}
}
}
},
"IDBDatabase": {
"name": "IDBDatabase",
"events": {
Expand Down Expand Up @@ -815,7 +772,7 @@
}
},
"IDBTransaction": {
"name": "IDBRequest",
"name": "IDBTransaction",
"events": {
"event": [
{
Expand All @@ -840,7 +797,7 @@
"property": {
"length": {
"name": "length",
"override-type": "number"
"type": "unsigned long"
}
}
},
Expand All @@ -866,11 +823,11 @@
"property": {
"prime": {
"name": "prime",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"generator": {
"name": "generator",
"override-type": "Uint8Array"
"type": "Uint8Array"
}
}
},
Expand All @@ -883,11 +840,11 @@
"property": {
"prime": {
"name": "prime",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"generator": {
"name": "generator",
"override-type": "Uint8Array"
"type": "Uint8Array"
}
}
},
Expand All @@ -900,7 +857,7 @@
"property": {
"prime": {
"name": "public",
"override-type": "CryptoKey"
"type": "CryptoKey"
}
}
},
Expand All @@ -913,11 +870,11 @@
"property": {
"prime": {
"name": "prime",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"generator": {
"name": "generator",
"override-type": "Uint8Array"
"type": "Uint8Array"
}
}
},
Expand All @@ -935,24 +892,24 @@
},
"algorithmId": {
"name": "algorithmId",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"partyUInfo": {
"name": "partyUInfo",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"partyVInfo": {
"name": "partyVInfo",
"override-type": "Uint8Array"
"type": "Uint8Array"
},
"publicInfo": {
"name": "publicInfo",
"override-type": "Uint8Array",
"type": "Uint8Array",
"required": 0
},
"privateInfo": {
"name": "privateInfo",
"override-type": "Uint8Array",
"type": "Uint8Array",
"required": 0
}
}
Expand Down Expand Up @@ -1011,7 +968,7 @@
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
"type": "Document"
}
}
}
Expand Down Expand Up @@ -1611,14 +1568,6 @@
"name": "HTMLTableHeaderCellElement",
"extends": "HTMLTableCellElement",
"exposed": "Window",
"properties": {
"property": {
"scope": {
"name": "scope",
"override-type": "string"
}
}
},
"element": [
{
"name": "th"
Expand Down Expand Up @@ -1772,12 +1721,12 @@
"x": {
"name": "x",
"read-only": 1,
"override-type": "SVGAnimatedLength"
"type": "SVGAnimatedLength"
},
"y": {
"name": "y",
"read-only": 1,
"override-type": "SVGAnimatedLength"
"type": "SVGAnimatedLength"
}
}
}
Expand All @@ -1791,7 +1740,7 @@
"targetElement": {
"name": "targetElement",
"read-only": 1,
"override-type": "SVGElement"
"type": "SVGElement"
}
}
},
Expand Down Expand Up @@ -2256,7 +2205,7 @@
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
"type": "Document"
}
}
}
Expand All @@ -2268,7 +2217,7 @@
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
"type": "Document"
}
}
}
Expand All @@ -2280,7 +2229,7 @@
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
"type": "Document"
}
}
}
Expand All @@ -2292,7 +2241,7 @@
"ownerDocument": {
"name": "ownerDocument",
"read-only": 1,
"override-type": "Document"
"type": "Document"
}
}
}
Expand Down Expand Up @@ -2398,7 +2347,7 @@
},
{
"new-type": "IDBKeyPath",
"override-type": "string"
"type": "DOMString"
},
{
"new-type": "Transferable",
Expand Down
2 changes: 0 additions & 2 deletions inputfiles/knownTypes.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"HmacKeyAlgorithm",
"HmacKeyGenParams",
"IDBKeyPath",
"IDBValidKey",
"ImageBitmapRenderingContextSettings",
"InsertPosition",
"KeyFormat",
Expand Down Expand Up @@ -111,7 +110,6 @@
"HmacImportParams",
"HmacKeyGenParams",
"IDBArrayKey",
"IDBValidKey",
"ImageBitmapRenderingContextSettings",
"MidiPermissionDescriptor",
"NamedCurve",
Expand Down
Loading