Skip to content

https://github.com/microsoft/TypeScript/issues/39655 #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

https://github.com/microsoft/TypeScript/issues/39655 #895

wants to merge 2 commits into from

Conversation

ShukantPal
Copy link
Contributor

This PR will add the following WebGL extension types:

WEBGL_compressed_texture_pvrtc
WEBGL_compressed_texture_etc1
WEBGL_compressed_texture_atc

@ShukantPal ShukantPal requested a review from sandersn as a code owner August 10, 2020 20:14
@ghost
Copy link

ghost commented Aug 10, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@HolgerJeromin
Copy link
Contributor

Ref as a clickable link: microsoft/TypeScript#39655

saschanaz
saschanaz suggested changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@saschanaz saschanaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do npm run fetch-idl "WebGL WEBGL_compressed_texture_pvrtc" "WebGL WEBGL_compressed_texture_etc1" and remove atc which is rejected.

saschanaz
saschanaz reviewed Aug 16, 2020
View reviewed changes
@ShukantPal
Copy link
Contributor Author

@saschanaz Done!

@saschanaz
Copy link
Contributor

Good, could you do npm run fetch-idl "WebGL WEBGL_compressed_texture_pvrtc" "WebGL WEBGL_compressed_texture_etc1" && npm run build && npm run baseline-accept and commit the results? Thanks! (Sorry that I omitted the build and accept part)

@orta orta mentioned this pull request Mar 8, 2021
Merged
@orta orta closed this in #989 Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz requested changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShukantPal @HolgerJeromin @saschanaz