Skip to content

Add keyCode attribute to KeyboardEventInit #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

Add keyCode attribute to KeyboardEventInit #892

merged 1 commit into from
Sep 11, 2020

Conversation

taejs
Copy link
Contributor

@taejs taejs commented Aug 4, 2020 •
edited
Loading

It's needed to fix cross browsing issue(support IE)

Fixes microsoft/TypeScript#15228

@taejs taejs requested a review from sandersn as a code owner August 4, 2020 10:30
@ghost
Copy link

ghost commented Aug 4, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@HolgerJeromin
Copy link
Contributor

Thanks for helping.
Is this a change in the widl from upstream?
I suspect no, so the correct place would be the addTypes.json

@taejs taejs force-pushed the keyboardEventInitMissingProps branch from 77aa3c0 to c2400a9 Compare August 5, 2020 16:47
@taejs @taerim-shin
Add keyCode attribute to KeyboardEventInit
8b0f76f 
It's needed to fix cross browsing issue(support IE)

Fixes #15228
@taejs taejs force-pushed the keyboardEventInitMissingProps branch from c2400a9 to 8b0f76f Compare August 5, 2020 16:48
@taejs
Copy link
Contributor Author

taejs commented Aug 5, 2020 •
edited
Loading

Thanks a lot! I finally found out how it goes

@saschanaz
Copy link
Contributor

saschanaz commented Aug 16, 2020 •
edited
Loading

I think this type of change should go to DefinitelyTyped with the name something like @types/ie.

Ah never mind, the UI Events spec has them but somehow they are excluded from IDL. I'll file a bug there. Edit: w3c/uievents#272

@orta
Copy link
Contributor

orta commented Sep 11, 2020

Yeah, we agree - let's get this in

@orta orta merged commit 6ed3a9e into microsoft:master Sep 11, 2020
@saschanaz saschanaz mentioned this pull request Sep 11, 2020
Merged
@taejs taejs deleted the keyboardEventInitMissingProps branch February 20, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyboardEventInit missing props
4 participants
@taejs @HolgerJeromin @saschanaz @orta