Skip to content

Restrict possible values of DataTransfer.dropEffect and DataTransfer.effectAllowed. #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

Restrict possible values of DataTransfer.dropEffect and DataTransfer.effectAllowed. #891

merged 2 commits into from
Sep 10, 2020

Conversation

hisomura
Copy link
Contributor

Now types of dropEffect and effectAllowed are string but comments restrict their values like below.

The possible values are "none", "copy", "link", and "move".
The possible values are "none", "copy", "copyLink", "copyMove", "link", "linkMove", "move", "all", and "uninitialized",

So I updated their types according to the comments.

@hisomura hisomura requested a review from sandersn as a code owner July 30, 2020 23:12
@ghost
Copy link

ghost commented Jul 30, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@sandersn sandersn merged commit ca4a0da into microsoft:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hisomura @sandersn