Adds testing the TypeScript repo against PR changes #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very likely to fail because a few of our tests dump dom types into the baselines, so it'll need to be integrated in a way that reports its diff without failing the build. |
|
These we go, that's giving some useful info now. |
sandersn
approved these changes
Dec 18, 2020
|
On Monday I'll do a run over any "very easy to scope and call myself" PRs and migrate them into TSC, then I'll merge this PR |
|
OK, that looks good to me, let's do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works out at a reasonable timeframe