Skip to content

Add contains to interface Node #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2015
Merged

Add contains to interface Node #8

merged 2 commits into from
Nov 6, 2015

Conversation

zhengbli
Copy link
Contributor

@mhegazy
Copy link
Contributor

mhegazy commented Nov 2, 2015

👍

zhengbli added a commit that referenced this pull request Nov 6, 2015
@zhengbli
Merge pull request #8 from Microsoft/i1253
5df353c 
Add contains to interface Node
@zhengbli zhengbli merged commit 5df353c into master Nov 6, 2015
@sccolbert
Copy link

contains() should also be removed from the HTMLElement interface.

Edit: Otherwise, you would be limited to testing for the presence of only HTMLElement children when dealing with an element, which would be incorrect.

@mhegazy mhegazy deleted the i1253 branch November 6, 2015 23:16
@zhengbli
Copy link
Contributor Author

zhengbli commented Nov 7, 2015

@sccolbert That makes sense. I'll update soon

orta pushed a commit to orta/TSJS-lib-generator that referenced this pull request Jun 23, 2021
@saschanaz
feat: fetch spec list from browser-specs (microsoft#8)
ea6034a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbli @mhegazy @sccolbert