Skip to content

Add minLength property to input & textarea #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2016

Conversation

michaelbromley
Copy link
Contributor

@msftclas
Copy link

Hi @michaelbromley, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@michaelbromley, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Feb 25, 2016

why was inputfiles/comments.json edited. github seems to think of it as a binary file.. does it have a BOM at the top?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 25, 2016

looks good except the comments file that i am not sure what is going on with.

@michaelbromley
Copy link
Contributor Author

I thought it was necessary to edit comments.json in order to provide comments for the new properties I added. Is it not the case?

No idea why it shows as a binary. I was like that even before I made changes. Should I just revert that file to the original then?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 26, 2016

i think it is a recent change to the github UI that makes files show as binaries.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 26, 2016

can you merge in master again. i have removed the BOM from the file.

@zhengbli
Copy link
Contributor

zhengbli commented Mar 2, 2016

👍 Thanks @michaelbromley !

zhengbli added a commit that referenced this pull request Mar 2, 2016
Add minLength property to input & textarea
@zhengbli zhengbli merged commit 6d23139 into microsoft:master Mar 2, 2016
@michaelbromley
Copy link
Contributor Author

You're welcome - TS is making my life a lot easier, happy to contribute back :)

orta pushed a commit to orta/TSJS-lib-generator that referenced this pull request Jun 23, 2021
…rosoft#69)

* chore(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.1.0

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.2.0 to 8.1.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v7.2.0...v8.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Remove obsolete prettier/@typescript-eslint

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants