-
Notifications
You must be signed in to change notification settings - Fork 439
Add minLength property to input & textarea #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @michaelbromley, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@michaelbromley, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
why was inputfiles/comments.json edited. github seems to think of it as a binary file.. does it have a BOM at the top? |
looks good except the comments file that i am not sure what is going on with. |
I thought it was necessary to edit comments.json in order to provide comments for the new properties I added. Is it not the case? No idea why it shows as a binary. I was like that even before I made changes. Should I just revert that file to the original then? |
i think it is a recent change to the github UI that makes files show as binaries. |
can you merge in master again. i have removed the BOM from the file. |
9d6a210
to
5553f89
Compare
👍 Thanks @michaelbromley ! |
Add minLength property to input & textarea
You're welcome - TS is making my life a lot easier, happy to contribute back :) |
…rosoft#69) * chore(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.1.0 Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.2.0 to 8.1.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v7.2.0...v8.1.0) Signed-off-by: dependabot[bot] <[email protected]> * Remove obsolete prettier/@typescript-eslint Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Fixes microsoft/TypeScript#7197
HTML5 spec:
https://www.w3.org/TR/html5/forms.html#the-maxlength-and-minlength-attributes