Remove redundant added types #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Apr 3, 2019
3 tasks
dbjorge
added a commit
to microsoft/accessibility-insights-web
that referenced
this pull request
Aug 14, 2019
…cript upgrade (#1065) Updating from Typescript 2.9 to 3.5 results in a variety of errors that look like this: ``` ERROR in Q:/repos/accessibility-insights-web/src/common/document-manipulator.ts(4,42): TS2304: Cannot find name 'NodeSelector'. ``` It looks like microsoft/TypeScript-DOM-lib-generator#647 was the point where it was removed, merged into a separate `ParentNode` interface. We considered using `ParentNode` instead here, but `Document` seemed closer to the intended usage in most cases and led to the tests working more similarly to the product code than anything else, so that's what I went with. Replacing the usages with Document is a no-op in Typescript 2.9 (so nice to do as a separate PR, to make the eventual Typescript upgrade PR smaller). It also forces the affected tests to be a little bit better (they create test documents for the cases where the product passes real documents, rather than creating test nodes within a global document and hoping that they act similarly and that no other test touches global document state).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElementCreationOptionsis already in IDLParentNodeis already in IDLBroadcastChannelEventMapis already defined elsewhere (we currently have two of them)NodeSelectorhas been merged intoParentNodeand is not used anymoreImageBitmapOptionsis covered by #571.