Skip to content

Add Clipboard Interfaces to idlSources #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2019

Conversation

Brcrwilliams
Copy link
Contributor

@Brcrwilliams Brcrwilliams commented Dec 13, 2018

Update ClipboardEventInit interface to match the W3C spec.
See microsoft/TypeScript#28998 for additional information.

@saschanaz
Copy link
Contributor

TS now prefers directly fetching W3C standard rather than manually maintaining types.

I recommend:

  1. Add the following item to the inputfiles/idlSources.json.

    {
      "url": "https://www.w3.org/TR/clipboard-apis/",
      "title": "Clipboard"
    }
  2. Remove ClipboardEventInit from addedType.json and also ClipboardEvent from overridingTypes.json.

  3. Run npm run fetch -- Clipboard

  4. Commit the result

@Brcrwilliams
Copy link
Contributor Author

@saschanaz Thank you for the guidance. That approach does sound better. I have applied those changes.

Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc: @DanielRosenwasser for additional review and merge.

Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, looks like Clipboard.read() and .write() should be removed for now because there is currently no consensus for those APIs. (w3c/clipboard-apis#84)

Please remove them via editing removedTypes.json and npm run build && npm run baseline-accept again. (Adding null there removes the corresponding item.)

@Brcrwilliams Brcrwilliams changed the title Update ClipboardEventInit to match W3C spec Add Clipboard Interfaces to idlSources Dec 14, 2018
Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sandersn
Copy link
Member

CI is broken from an earlier change. I'll merge again when I've fixed it.

@saschanaz
Copy link
Contributor

Looks like something weird happened when merging.

@sandersn
Copy link
Member

Yep, I wasn't supposed to include the inputfiles/idl updates.

…TSJS-lib-generator into Brcrwilliams-ClipboardEventInit"

This reverts commit 1711c97, reversing
changes made to f197190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants