-
Notifications
You must be signed in to change notification settings - Fork 440
Add Clipboard Interfaces to idlSources #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TS now prefers directly fetching W3C standard rather than manually maintaining types. I recommend:
|
03fb14a
to
1411f66
Compare
@saschanaz Thank you for the guidance. That approach does sound better. I have applied those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc: @DanielRosenwasser for additional review and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, looks like Clipboard.read()
and .write()
should be removed for now because there is currently no consensus for those APIs. (w3c/clipboard-apis#84)
Please remove them via editing removedTypes.json
and npm run build && npm run baseline-accept
again. (Adding null
there removes the corresponding item.)
1411f66
to
4c9aa8c
Compare
4c9aa8c
to
1bd4980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…-generator into Brcrwilliams-ClipboardEventInit
CI is broken from an earlier change. I'll merge again when I've fixed it. |
Looks like something weird happened when merging. |
Yep, I wasn't supposed to include the inputfiles/idl updates. |
Update ClipboardEventInit interface to match the W3C spec.
See microsoft/TypeScript#28998 for additional information.