Skip to content

Make HTMLElement.nonce optional #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2019
Merged

Make HTMLElement.nonce optional #626

merged 2 commits into from
Jan 18, 2019

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Dec 3, 2018 •
edited
Loading

Addresses microsoft/TypeScript#28452

I'm not entirely sure if my solution is the correct way to do it or if I should add some logic to emitter for creating optional properties.

This change is Reviewable

@msftclas
Copy link

msftclas commented Dec 3, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@deiga deiga mentioned this pull request Dec 3, 2018
Closed
sandersn
sandersn approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good step although it sounds like maybe nonce should be removed entirely.

@sandersn sandersn merged commit 147ec33 into microsoft:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deiga @msftclas @sandersn