Skip to content

Fix lib breaks #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 2, 2018
Merged

Fix lib breaks #560

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0ad4fd6
Add optional parameter to reload.
mhegazy Aug 2, 2018
fbeb94b
Change the type of `Window.onerror` to `ErrorEventHandler`
mhegazy Aug 2, 2018
d838ee1
Set `Node.parentElement` to `HTMLElement`
mhegazy Aug 2, 2018
d919087
Add additional fourth argument to `Document.createTreeWalker`
mhegazy Aug 2, 2018
ba26044
Add `Document.caretRangeFromPoint`
mhegazy Aug 2, 2018
2fa7ed7
Add `namespaceURI` on `Node`
mhegazy Aug 2, 2018
667a1e4
Add back `MouseWheelEvent`
mhegazy Aug 2, 2018
0ddea9b
Fix build break
mhegazy Aug 2, 2018
79c60b8
Make `Document.body` non-nullable
mhegazy Aug 2, 2018
ba2728a
Add back `Event.srcElement` declaration
mhegazy Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9282,7 +9282,7 @@ interface Location {
/**
* Reloads the current page.
*/
reload(): void;
reload(forcedReload?: boolean): void;
Copy link
Contributor

@saschanaz saschanaz Aug 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not browser"s" because its Firefox specific. https://bugzilla.mozilla.org/show_bug.cgi?id=1037721

Not in current Chromium: https://chromium.googlesource.com/chromium/blink/+/master/Source/core/frame/Location.idl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change it to two overloads and mark it as deprecated.

/**
* Removes the current page from the session history and navigates to the given URL.
*/
Expand Down
11 changes: 11 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2313,6 +2313,17 @@
"[index: number]: Element",
"[name: string]: any"
]
},
"Location": {
"methods": {
"method": {
"reload": {
"override-signatures": [
"reload(forcedReload?: boolean): void"
]
}
}
}
}
}
},
Expand Down