Make package name scoped to @typescript #1902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me but the merge should happen from @sandersn. Note that users in general should use |
sandersn
requested changes
Feb 4, 2025
Co-authored-by: Nathan Shively-Sanders <[email protected]>
zombie
changed the title
|
Oops, pushed the wrong button. I accepted the proposed change, and renamed the PR. This is now ready to be merged. |
sandersn
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this package name was name squatted on npm by a malicious actor: GHSA-5h3m-q8pm-rw64.
The issue is that anyone importing this package gets a "critical severity vulnerability" because of the package name. Making the package name scoped to @microsoft avoids any confusion today, and guards against any potential future npm substitution attacks.