Skip to content

fix: add icecandidateerror type #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ntsd
Copy link
Contributor

@ntsd ntsd commented Dec 19, 2023

  • use RTCPeerConnectionIceErrorEvent for icecandidateerror event type

Reference: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/icecandidateerror_event

- use RTCPeerConnectionIceErrorEvent for icecandidateerror event type
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@ntsd
Copy link
Contributor Author

ntsd commented Dec 19, 2023

@ntsd please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@saschanaz
Copy link
Contributor

Included in #1660, but LGTM anyway.

@github-actions github-actions bot merged commit 87cdc80 into microsoft:main Dec 19, 2023
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants