Add the missing "disabled" property to HTMLStyleElement #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to HTMLStyleElement
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Mar 31, 2022
There was a problem hiding this comment.
First, you are looking at a legacy spec, the correct one doesn't have it: https://html.spec.whatwg.org/multipage/semantics.html#htmlstyleelement
But that said, it's true that every browser has it and the spec wants to define it: whatwg/html#5590
So yeah, let's do this.
inputfiles/addedTypes.jsonc
Outdated
| @@ -1126,6 +1126,17 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
| "HTMLStyleElement": { | |||
| "name": "HTMLStyleElement", | |||
There was a problem hiding this comment.
This line is redundant, please remove it.
There was a problem hiding this comment.
Thank you, I updated the code to remove it
|
lgtm |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#42266
Look like the
HTMLStyleElement.disabledproperty is defined in the specs, also available on every browser, according to MDN.