fix: audioworklet registerProcessor should expect a constructor not a function #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Could you add a unit test too? And I wonder a new type is needed here: interface AudioWorkletProcessorImpl extends AudioWorkletProcessor {
process(...);
}
interface AudioWorkletProcessorConstructor {
new (options: any): AudioWorkletProcessorImpl;
} |
|
Will look into it... |
|
closes also #1298 |
mathe42
commented
Mar 23, 2022
| @@ -0,0 +1,8 @@ | |||
| registerProcessor( | |||
There was a problem hiding this comment.
Added test in extra folder as other files has to be included. If other setup is needed say how to change it.
yume-chan
reviewed
Mar 23, 2022
|
lgtm Thank you! |
|
@saschanaz did not get merged!? |
|
Hmm? LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1295
see also https://developer.mozilla.org/en-US/docs/Web/API/AudioWorkletProcessor/AudioWorkletProcessor