feat: add serviceworkerRegistration.navigationPreload #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
This was removed by 3575d1b when BCD didn't have the relevant item, but it now does and is supported by all three browser (except Firefox where it's still in beta stage mdn/browser-compat-data#15414). It meets the standard to be added, so: lgtm |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now get support in FF Nightly and Safari TP so I think this can be added now. (Not 100% shure as we only have it stable in chromium)
see https://developer.mozilla.org/en-US/docs/Web/API/NavigationPreloadManager#browser_compatibility
feel free to close this (or don't merge it) until we get 2 stable implementations...