Skip to content

feat: add web loocks api #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2022
Merged

feat: add web loocks api #1291

merged 2 commits into from
Mar 15, 2022

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Mar 15, 2022

This fixes #1248 wich was closed by #1247 but wasn't exposed on navigator.

This PR fixes that.

Note: This is my first PR in this project so I hope I did evrything correctly...

@ghost
Copy link

ghost commented Mar 15, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

saschanaz commented Mar 15, 2022

Thank you, this looks great! Please sign CLA and then I'll merge this.

Edit: Oh you did it quick!

@mathe42
Copy link
Contributor Author

mathe42 commented Mar 15, 2022

Signed it.

@saschanaz
Copy link
Contributor

lgtm

@github-actions github-actions bot merged commit e963a34 into microsoft:main Mar 15, 2022
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@mathe42
Copy link
Contributor Author

mathe42 commented Mar 15, 2022

Thanks for the fast merge!

@mathe42 mathe42 deleted the patch-1 branch March 15, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigator.locks is missing
2 participants