Add loading attribute for HTMLIframeElement #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
1000ch
force-pushed
the
loading-attribute-for-iframe
branch
from
8e699d7 to
f86ca91
Compare
1000ch
force-pushed
the
loading-attribute-for-iframe
branch
from
5406a71 to
160700d
Compare
1000ch
force-pushed
the
loading-attribute-for-iframe
branch
from
160700d to
1333865
Compare
Bashamega
suggested changes
Mar 28, 2025
Bashamega
suggested changes
Mar 29, 2025
|
Needs to be reviewed by @saschanaz ? |
Yes |
|
LGTM, thanks! |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
|
And thanks @Bashamega for picking up missed PRs! |
You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadingattribuets for<iframe>element.'eager' | 'lazy'instead ofstringas a type forloadingattributes