Skip to content

Adds 4.5 READMEs, and makes the files match up to the versions in the… #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

Adds 4.5 READMEs, and makes the files match up to the versions in the… #1161

merged 1 commit into from
Oct 1, 2021

Conversation

sandersn
Copy link
Member

… spec

As requested by @orta

@sandersn sandersn requested a review from orta September 30, 2021 16:19
HolgerJeromin
HolgerJeromin suggested changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@HolgerJeromin HolgerJeromin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links are broken

@orta
Copy link
Contributor

orta commented Oct 1, 2021

Thanks @HolgerJeromin!

@orta orta merged commit cfd92b5 into microsoft:main Oct 1, 2021
@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Oct 1, 2021 •
edited
Loading

@orta
The PR was merged in the "buggy" state (and not fixed afterwards).

https://github.com/microsoft/TypeScript-DOM-lib-generator/blob/main/deploy/readmes/serviceworker.md

image

@orta
Copy link
Contributor

orta commented Oct 1, 2021

oh weird, I though I accepted all those and then merged - thanks

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Oct 1, 2021 •
edited
Loading

This were many comments in a wrapping review.
Perhaps you needed to approve all of them (as you did) but then commit all changes in a bunch (this is the work flow of azure devops at least).
What ever :)

@orta
Copy link
Contributor

orta commented Oct 1, 2021

Thanks, I manually pushed that change to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HolgerJeromin HolgerJeromin HolgerJeromin requested changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandersn @orta @HolgerJeromin