Adds targets for the other environments #1062
Conversation
|
Going to give this the weekend for TS team members to give any feedback, will merge on Monday 👍🏻 |
deploy/createTypesPackages.mjs
Outdated
| readme: "./readmes/serviceworker.md", | ||
| files: [ | ||
| { from: "../generated/serviceworker.generated.d.ts", to: "index.d.ts" }, | ||
| { from: "../generated/serviceworker.iterable.generated.d.ts", to: "index.iterable.d.ts" }, |
There was a problem hiding this comment.
While you are at it: how can index.iterable.d.ts be referenced? 👀 Should the step be added to readme?
There was a problem hiding this comment.
Hrm, I thought it would be automatically be included in all builds because it lives in @types and we read all the files in there. Haven't actually checked though.
There was a problem hiding this comment.
Somehow it doesn't work like that in my environment (see there is no index.iterable.d.ts):
There was a problem hiding this comment.
Agree, the build pipeline will probably need to add something like /// <reference path="..." /> to the index.dt.s
A user can probably get these imported into their globals via import "web/index.iterable" but that's weaksauce
There was a problem hiding this comment.
But that would mean packages will require es6+ 🤔
There was a problem hiding this comment.
Adding /// <reference path="./index.iterable.d.ts" /> to the top of index.d.ts automatically includes it. I think this is a reasonable enough default if we document it as supporting ES6+
There was a problem hiding this comment.
Yeah, since it's probably time to concentrate on es6+ 😁
Adds support for deploying:
@types/webworker@types/serviceworker@types/audioworklet@types/sharedworker@types/sharedworkeralready exists and was removed from DT by me back in 3.9 - DefinitelyTyped/DefinitelyTyped#43366 - the deployment infra will see this and release this version as0.0.30.