-
Notifications
You must be signed in to change notification settings - Fork 439
Add DefinitelyTyped tests to CI #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orta
wants to merge
19
commits into
main
Choose a base branch
from
try_dt_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a5ad86e
Try tests on DT
orta eb52ca5
Merge branch 'main' into try_dt_tests
orta fc21c6d
Logs
orta 881afb5
Yarn
orta e53349c
Moves the generated dom into the TS node_module
orta e0a7a6e
Log version
orta d3ca587
Use my 4.3 branch of DT tools
orta 0870e8e
Checkout origin
orta 2aaf12e
Checkout the right place
orta 151fa35
Use the npm version of dtslint-runner
orta 55e89c3
Log the dtslint logs on CI
orta daea349
use 1 index
orta 65dc808
matrix
orta d382107
Shards
orta e5ee9b2
Comments
orta 0090d28
Split setup vs test in DT tests
orta a22f5d3
Only run on PR
orta 737bb63
Try continue on error
orta 29d32c4
Add a nightly run also
orta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: Test DT subset | ||
on: [push, pull_request] | ||
|
||
jobs: | ||
test_shard: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
job_position: [1, 2, 3, 4, 5, 6] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: "15.x" | ||
registry-url: "https://registry.npmjs.org" | ||
- run: npm install | ||
- run: npm run build | ||
|
||
- name: Setup | ||
run: | | ||
mkdir tester | ||
cd tester | ||
yarn init -y | ||
yarn add typescript@next | ||
yarn add @definitelytyped/dtslint-runner | ||
|
||
cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts node_modules/typescript/lib/lib.dom.d.ts | ||
cp $GITHUB_WORKSPACE/generated/dom.iterable.generated.d.ts node_modules/typescript/lib/lib.dom.iterable.d.ts | ||
cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts node_modules/typescript/lib/lib.webworker.d.ts | ||
cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts | ||
|
||
echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" | ||
yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt | ||
branchRunResult=$ | ||
|
||
echo | ||
echo "=== Errors only in nightly ===" | ||
diff --changed-group-format='%<' --unchanged-group-format='' nightlyErrors.txt branchErrors.txt | egrep -v '^(===|[12]>)' | ||
|
||
echo | ||
echo "=== Errors only in branch ===" | ||
diff --changed-group-format='%>' --unchanged-group-format='' nightlyErrors.txt branchErrors.txt | egrep -v '^(===|[12]>)' | ||
|
||
exit $branchRunResult | ||
env: | ||
SYSTEM_JOBPOSITIONINPHASE: ${{ matrix.job_position }} | ||
SYSTEM_TOTALJOBSINPHASE: "6" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.