-
Notifications
You must be signed in to change notification settings - Fork 441
Merge types_web back into TypeScript DOM lib generator #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 250 commits
fe5f1cd
461adc9
357169a
6fec72b
9291a3c
624fb0a
55788a4
3b2f317
d8bf7ce
95205b0
67318f4
a4c9b59
0f69d55
6ea491b
335bed1
7ca5ce7
1a2a9b6
b0a63e3
b5463ad
ea6034a
89f0ceb
749da81
9072a3c
f0be902
d91e8ba
d848f85
411ae2e
4ad3437
32e0a60
0506730
5e59677
52946af
b75a0cd
db97ff8
ef01309
8d5a633
5f23c5c
73a5ec7
f9f2c6c
5d2b545
a4969b8
617051f
7f3608f
c762386
c0290cb
1f43a8d
d5688b8
20bcd49
5fd7f1a
e20c9d1
5b0c618
a7000c2
d1e6d31
8c7d035
a8551da
6a13641
474c2cb
b2b1943
94814b7
e3f46d9
d1d1946
335a660
5c1219f
c214d51
138255f
d0e0e00
2bffd44
8a2a6b0
c63fdcc
5f4f8a2
766d6aa
a2b90c8
f3374e5
0f39df1
24bcae1
268e637
191ea44
e5a189f
63ef20d
ab89e58
e234de1
cf58be0
7406648
95cf1c1
7c05e57
8fca3db
74678d7
455f902
ea85b89
4dc8248
aba4766
a738e8c
1d101f5
4878ace
2cd8ad3
cbce2d9
ca98122
e507c47
44bdec9
95be3fe
f78b5b6
0afeec5
216c71d
9c6f532
4dc41d6
b15b2a6
106abcb
903e960
39d238b
dc371cf
467f05c
15d5474
e6a33a6
def642d
b3881e2
76c487a
9e55e83
535341b
1fee742
e0562d6
f8cb4e8
184b0e6
b1a832d
0cabe70
aa603a4
6767562
2ed98ce
4b66e21
24bc5a4
800e903
43b2f82
5b799f2
eafed28
4f445e0
af530a6
a467892
579372a
bfe9798
5b7fd47
408e26f
fc483d7
cb816ba
eaeee2f
9a94261
2b3ec68
2a812f4
90af280
be8fff5
3d29047
26a4ddd
b485e9e
076ca2b
d9d4a14
20183b7
a225373
5888b03
9b89bc2
1eefcb6
7fcd30d
2a8706d
5798d06
034fa81
0e44eb7
39b3171
d0728b0
415da69
5634c07
9c75780
3def312
2457c0a
5ab8e93
b4b6bbf
3d783b2
6186734
d67702b
a5d0b07
34e3b27
3356c96
3a24bfa
b8a56a3
4ef63f6
65f4f65
c08fd72
860e3e7
9a4d336
933c22d
6bd4918
05e0a90
87021dc
276da88
b32712d
6b32439
73542a7
77050b1
b169ebb
0f24f76
05cbd93
82fbfeb
87dd612
da12590
3d88f14
0c5fbbf
148b083
f2a93cf
33caefc
70ba5e0
80fb08f
69e842f
d3dfe92
a6fb2dc
84aa732
8e475e1
f50eeeb
06207b4
f40e338
3ba381f
19c6039
589ee43
5ff34fc
44af381
640ada9
ab95065
6ef3251
0fab4e6
5f78617
4342980
6b44938
7b2675f
850b7eb
7704232
91408ba
be147c6
7e6fbde
d1ff27f
785ee82
f3b86f5
dec51c4
5288d88
25a2c27
40e10bb
1b8d3e1
d384b28
a340b80
887c60c
a88f594
3976f06
619d4e8
6c61dab
bc40006
01e8285
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Basic dependabot.yml file | ||
# https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/enabling-and-disabling-version-updates | ||
|
||
version: 2 | ||
updates: | ||
# Enable version updates for npm | ||
- package-ecosystem: "npm" | ||
# Look for `package.json` and `lock` files in the `root` directory | ||
directory: "/" | ||
# Check the npm registry for updates every month | ||
schedule: | ||
interval: "monthly" | ||
# Bump versions in package.json | ||
# https://github.com/dependabot/dependabot-core/issues/3103 | ||
# https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#versioning-strategy | ||
versioning-strategy: "increase" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,6 @@ jobs: | |
with: | ||
node-version: '15' | ||
|
||
- run: npm install | ||
- run: npm ci | ||
- run: npm run build | ||
- run: npm test |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: Update core dependencies | ||
on: | ||
workflow_dispatch: | ||
schedule: | ||
# https://crontab.guru/#5_8_*_*_* | ||
- cron: "5 8 * * *" | ||
|
||
# Conditional runs | ||
# https://stackoverflow.com/a/61832535/2460034 | ||
jobs: | ||
update-webref: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: '15' | ||
|
||
- run: npm i -g npm-check-updates | ||
- run: ncu -u | ||
- run: npm i | ||
- run: npm run build && npm run baseline-accept | ||
- id: git-diff | ||
run: git diff --quiet HEAD baselines | ||
continue-on-error: true | ||
- uses: peter-evans/create-pull-request@v3 | ||
if: ${{ steps.git-diff.outcome == 'failure' }} | ||
with: | ||
commit-message: "chore(package): update core dependencies" | ||
title: "chore(package): update core dependencies" | ||
branch: update-core-deps | ||
token: ${{ secrets.PAT }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
package-lock=false | ||
message="chore(package): bump version number to v%s" |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,12 @@ | ||
# TypeScript and JavaScript lib generator | ||
|
||
Travis CI Status: [](https://travis-ci.org/Microsoft/TSJS-lib-generator) | ||
This tool is used to generate the web-based `lib.dom.d.ts` file which is included with TypeScript releases, and as the `@types/web` package. | ||
|
||
This tool is used to generate `dom.generated.d.ts`, `webworker.generated.d.ts` and `dom.iterable.generated.d.ts` for TypeScript. | ||
The input file is the JSON webidl file generated by the Microsoft Edge browser. | ||
## Why is my fancy API still not available here? | ||
|
||
A feature needs to be supported by more than two major browser engines to be included here, to make sure there is a good consensus among vendors: __Gecko__ (Firefox), __Blink__ (Chrome/Edge), and __WebKit__ (Safari). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought it was 'two or more'. |
||
|
||
If the condition is met but still is not available here, please [file an issue](hthttps://github.com/microsoft/TypeScript-DOM-lib-generator/issues/new). | ||
|
||
## Build Instructions | ||
|
||
|
@@ -53,11 +56,10 @@ The format of each file can be inferred from their existing content. | |
|
||
The common steps to send a pull request are: | ||
|
||
0. Open or refer to an issue in the [TypeScript repo](https://github.com/Microsoft/TypeScript). | ||
1. Add missing elements to `inputfiles/addedTypes.json`, overriding elements to `inputfiles/overridingTypes.json`, or elements to remove to `inputfiles/removedTypes.json`. | ||
0. Open or refer to an issue in the [TypeScript repo](https://github.com/Microsoft/TypeScript) which might get moved back to this repo. | ||
1. Update an IDL or add missing elements to `inputfiles/addedTypes.json`, overriding elements to `inputfiles/overridingTypes.json`, or elements to remove to `inputfiles/removedTypes.json`. | ||
2. Run the build script locally to obtain new `dom.generated.d.ts` and `webworker.generated.d.ts`. | ||
3. Update the files in the `baselines` folder using the newly generated files | ||
under `generated` folder (`npm run baseline-accept`). | ||
3. Update the files in the `baselines` folder using the newly generated files under `generated` folder (`npm run baseline-accept`). | ||
|
||
### What are the TypeScript team's heuristics for PRs to the DOM APIs | ||
|
||
|
@@ -95,6 +97,8 @@ To give you a sense of whether we will accept changes, you can use these heurist | |
- Does an internet search for the fields show results in blogs/recommendations? | ||
- When was the deprecation (this can be hard to find) but was it at least 2 years ago if so? | ||
|
||
## Build Instructions | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this looks unfinished There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks it was a merge error - this is a dupe from the top |
||
|
||
# This repo | ||
|
||
## Code Structure | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Note that this does need a GitHub secret, so please add it when merging this.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be switched to
GITHUB_TOKEN
as this is running in a context where it will have a write tokenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing that will cause GH action triggering issue since PRs written by GITHUB_TOKEN does not trigger any other GH action.