Skip to content

Typo in MediaTrackConstraintSet's echoCancellation Property #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iStefo opened this issue May 12, 2017 · 0 comments
Closed

Typo in MediaTrackConstraintSet's echoCancellation Property #251

iStefo opened this issue May 12, 2017 · 0 comments

Comments

@iStefo
Copy link

iStefo commented May 12, 2017 •
edited
Loading

As discussed in microsoft/TypeScript#15175, the property on MediaTrackConstraintSet should be called echoCancellation but is currently misspelled as echoCancelation.

I tried to send a PR fixing this, but it seems to me like the generated interface comes from browser.webidl.xml (I couldn't find the specific property in any of the .json files) and the readme explicitly says to not edit this file.

Would this be an appropriate case to use the overridingTypes.json? Wouldn't it be better to fix this "upstream" in Edge itself?
@iStefo iStefo mentioned this issue May 12, 2017
Closed
chris-morgan added a commit to chris-morgan/TSJS-lib-generator that referenced this issue Sep 16, 2017
@chris-morgan
Fix MediaTrackConstraintSet echoCancellation typo
f6f48a0 
echoCancelation → echoCancellation

When Edge fixes its typo, this should be reverted.

Fixes microsoft#251.
This was referenced Sep 16, 2017
Closed
Closed
@mhegazy mhegazy mentioned this issue Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iStefo