Skip to content

Commit fd02fcc

Browse files
author
falsandtru
committed
Remove ElementTagNameMap
1 parent a023ee0 commit fd02fcc

File tree

3 files changed

+18
-16
lines changed

3 files changed

+18
-16
lines changed

TS.fsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -793,19 +793,22 @@ module Emit =
793793
/// Emit overloads for the getElementsByTagName method
794794
let EmitGetElementsByTagNameOverloads (m: Browser.Method) =
795795
if matchSingleParamMethodSignature m "getElementsByTagName" "NodeList" "string" then
796-
Pt.Printl "getElementsByTagName<K extends keyof ElementTagNameMap>(%s: K): NodeListOf<ElementTagNameMap[K]>;" m.Params.[0].Name
796+
Pt.Printl "getElementsByTagName<K extends keyof HTMLElementTagNameMap>(%s: K): NodeListOf<HTMLElementTagNameMap[K]>;" m.Params.[0].Name
797+
Pt.Printl "getElementsByTagName<K extends keyof SVGElementTagNameMap>(%s: K): NodeListOf<SVGElementTagNameMap[K]>;" m.Params.[0].Name
797798
Pt.Printl "getElementsByTagName(%s: string): NodeListOf<Element>;" m.Params.[0].Name
798799

799800
/// Emit overloads for the querySelector method
800801
let EmitQuerySelectorOverloads (m: Browser.Method) =
801802
if matchSingleParamMethodSignature m "querySelector" "Element" "string" then
802-
Pt.Printl "querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null;"
803+
Pt.Printl "querySelector<K extends keyof HTMLElementTagNameMap>(selectors: K): HTMLElementTagNameMap[K] | null;"
804+
Pt.Printl "querySelector<K extends keyof SVGElementTagNameMap>(selectors: K): SVGElementTagNameMap[K] | null;"
803805
Pt.Printl "querySelector<E extends Element = Element>(selectors: string): E | null;"
804806

805807
/// Emit overloads for the querySelectorAll method
806808
let EmitQuerySelectorAllOverloads (m: Browser.Method) =
807809
if matchSingleParamMethodSignature m "querySelectorAll" "NodeList" "string" then
808-
Pt.Printl "querySelectorAll<K extends keyof ElementTagNameMap>(selectors: K): NodeListOf<ElementTagNameMap[K]>;"
810+
Pt.Printl "querySelectorAll<K extends keyof HTMLElementTagNameMap>(selectors: K): NodeListOf<HTMLElementTagNameMap[K]>;"
811+
Pt.Printl "querySelectorAll<K extends keyof SVGElementTagNameMap>(selectors: K): NodeListOf<SVGElementTagNameMap[K]>;"
809812
Pt.Printl "querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;"
810813

811814
let EmitHTMLElementTagNameMap () =
@@ -828,10 +831,6 @@ module Emit =
828831
Pt.Printl "}"
829832
Pt.Printl ""
830833

831-
let EmitElementTagNameMap () =
832-
Pt.Printl "interface ElementTagNameMap extends HTMLElementTagNameMap, SVGElementTagNameMap { }"
833-
Pt.Printl ""
834-
835834
/// Emit overloads for the createEvent method
836835
let EmitCreateEventOverloads (m: Browser.Method) =
837836
if matchSingleParamMethodSignature m "createEvent" "Event" "string" then
@@ -1515,7 +1514,6 @@ module Emit =
15151514
if flavor <> Worker then
15161515
EmitHTMLElementTagNameMap()
15171516
EmitSVGElementTagNameMap()
1518-
EmitElementTagNameMap()
15191517
EmitNamedConstructors()
15201518

15211519
match GetGlobalPollutor flavor with

baselines/dom.generated.d.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3243,7 +3243,8 @@ interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEven
32433243
* Retrieves a collection of objects based on the specified element name.
32443244
* @param name Specifies the name of an element.
32453245
*/
3246-
getElementsByTagName<K extends keyof ElementTagNameMap>(tagname: K): NodeListOf<ElementTagNameMap[K]>;
3246+
getElementsByTagName<K extends keyof HTMLElementTagNameMap>(tagname: K): NodeListOf<HTMLElementTagNameMap[K]>;
3247+
getElementsByTagName<K extends keyof SVGElementTagNameMap>(tagname: K): NodeListOf<SVGElementTagNameMap[K]>;
32473248
getElementsByTagName(tagname: string): NodeListOf<Element>;
32483249
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/1999/xhtml", localName: string): HTMLCollectionOf<HTMLElement>;
32493250
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/2000/svg", localName: string): HTMLCollectionOf<SVGElement>;
@@ -3600,7 +3601,8 @@ interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelec
36003601
getAttributeNS(namespaceURI: string, localName: string): string;
36013602
getBoundingClientRect(): ClientRect;
36023603
getClientRects(): ClientRectList;
3603-
getElementsByTagName<K extends keyof ElementTagNameMap>(name: K): NodeListOf<ElementTagNameMap[K]>;
3604+
getElementsByTagName<K extends keyof HTMLElementTagNameMap>(name: K): NodeListOf<HTMLElementTagNameMap[K]>;
3605+
getElementsByTagName<K extends keyof SVGElementTagNameMap>(name: K): NodeListOf<SVGElementTagNameMap[K]>;
36043606
getElementsByTagName(name: string): NodeListOf<Element>;
36053607
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/1999/xhtml", localName: string): HTMLCollectionOf<HTMLElement>;
36063608
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/2000/svg", localName: string): HTMLCollectionOf<SVGElement>;
@@ -3629,7 +3631,8 @@ interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelec
36293631
webkitRequestFullScreen(): void;
36303632
getElementsByClassName(classNames: string): NodeListOf<Element>;
36313633
matches(selector: string): boolean;
3632-
closest<K extends keyof ElementTagNameMap>(selector: K): ElementTagNameMap[K] | null;
3634+
closest<K extends keyof HTMLElementTagNameMap>(selector: K): HTMLElementTagNameMap[K] | null;
3635+
closest<K extends keyof SVGElementTagNameMap>(selector: K): SVGElementTagNameMap[K] | null;
36333636
closest(selector: string): Element | null;
36343637
scrollIntoView(arg?: boolean | ScrollIntoViewOptions): void;
36353638
scroll(options?: ScrollToOptions): void;
@@ -14131,9 +14134,11 @@ interface NavigatorUserMedia {
1413114134
}
1413214135

1413314136
interface NodeSelector {
14134-
querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null;
14137+
querySelector<K extends keyof HTMLElementTagNameMap>(selectors: K): HTMLElementTagNameMap[K] | null;
14138+
querySelector<K extends keyof SVGElementTagNameMap>(selectors: K): SVGElementTagNameMap[K] | null;
1413514139
querySelector<E extends Element = Element>(selectors: string): E | null;
14136-
querySelectorAll<K extends keyof ElementTagNameMap>(selectors: K): NodeListOf<ElementTagNameMap[K]>;
14140+
querySelectorAll<K extends keyof HTMLElementTagNameMap>(selectors: K): NodeListOf<HTMLElementTagNameMap[K]>;
14141+
querySelectorAll<K extends keyof SVGElementTagNameMap>(selectors: K): NodeListOf<SVGElementTagNameMap[K]>;
1413714142
querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;
1413814143
}
1413914144

@@ -15024,8 +15029,6 @@ interface SVGElementTagNameMap {
1502415029
"view": SVGViewElement;
1502515030
}
1502615031

15027-
interface ElementTagNameMap extends HTMLElementTagNameMap, SVGElementTagNameMap { }
15028-
1502915032
declare var Audio: { new(src?: string): HTMLAudioElement; };
1503015033
declare var Image: { new(width?: number, height?: number): HTMLImageElement; };
1503115034
declare var Option: { new(text?: string, value?: string, defaultSelected?: boolean, selected?: boolean): HTMLOptionElement; };

inputfiles/addedTypes.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,8 @@
458458
"kind": "method",
459459
"interface": "Element",
460460
"signatures": [
461-
"closest<K extends keyof ElementTagNameMap>(selector: K): ElementTagNameMap[K] | null"
461+
"closest<K extends keyof HTMLElementTagNameMap>(selector: K): HTMLElementTagNameMap[K] | null",
462+
"closest<K extends keyof SVGElementTagNameMap>(selector: K): SVGElementTagNameMap[K] | null"
462463
]
463464
},
464465
{

0 commit comments

Comments
 (0)