Skip to content

Commit a023ee0

Browse files
author
falsandtru
committed
Remove ElementListTagNameMap
1 parent 361b981 commit a023ee0

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

TS.fsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ module Emit =
793793
/// Emit overloads for the getElementsByTagName method
794794
let EmitGetElementsByTagNameOverloads (m: Browser.Method) =
795795
if matchSingleParamMethodSignature m "getElementsByTagName" "NodeList" "string" then
796-
Pt.Printl "getElementsByTagName<K extends keyof ElementListTagNameMap>(%s: K): ElementListTagNameMap[K];" m.Params.[0].Name
796+
Pt.Printl "getElementsByTagName<K extends keyof ElementTagNameMap>(%s: K): NodeListOf<ElementTagNameMap[K]>;" m.Params.[0].Name
797797
Pt.Printl "getElementsByTagName(%s: string): NodeListOf<Element>;" m.Params.[0].Name
798798

799799
/// Emit overloads for the querySelector method
@@ -805,7 +805,7 @@ module Emit =
805805
/// Emit overloads for the querySelectorAll method
806806
let EmitQuerySelectorAllOverloads (m: Browser.Method) =
807807
if matchSingleParamMethodSignature m "querySelectorAll" "NodeList" "string" then
808-
Pt.Printl "querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K];"
808+
Pt.Printl "querySelectorAll<K extends keyof ElementTagNameMap>(selectors: K): NodeListOf<ElementTagNameMap[K]>;"
809809
Pt.Printl "querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;"
810810

811811
let EmitHTMLElementTagNameMap () =
@@ -832,12 +832,6 @@ module Emit =
832832
Pt.Printl "interface ElementTagNameMap extends HTMLElementTagNameMap, SVGElementTagNameMap { }"
833833
Pt.Printl ""
834834

835-
let EmitElementListTagNameMap () =
836-
Pt.Printl "type ElementListTagNameMap = {"
837-
Pt.PrintWithAddedIndent "[key in keyof ElementTagNameMap]: NodeListOf<ElementTagNameMap[key]>"
838-
Pt.Printl "};"
839-
Pt.Printl ""
840-
841835
/// Emit overloads for the createEvent method
842836
let EmitCreateEventOverloads (m: Browser.Method) =
843837
if matchSingleParamMethodSignature m "createEvent" "Event" "string" then
@@ -1522,7 +1516,6 @@ module Emit =
15221516
EmitHTMLElementTagNameMap()
15231517
EmitSVGElementTagNameMap()
15241518
EmitElementTagNameMap()
1525-
EmitElementListTagNameMap()
15261519
EmitNamedConstructors()
15271520

15281521
match GetGlobalPollutor flavor with

baselines/dom.generated.d.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3243,7 +3243,7 @@ interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEven
32433243
* Retrieves a collection of objects based on the specified element name.
32443244
* @param name Specifies the name of an element.
32453245
*/
3246-
getElementsByTagName<K extends keyof ElementListTagNameMap>(tagname: K): ElementListTagNameMap[K];
3246+
getElementsByTagName<K extends keyof ElementTagNameMap>(tagname: K): NodeListOf<ElementTagNameMap[K]>;
32473247
getElementsByTagName(tagname: string): NodeListOf<Element>;
32483248
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/1999/xhtml", localName: string): HTMLCollectionOf<HTMLElement>;
32493249
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/2000/svg", localName: string): HTMLCollectionOf<SVGElement>;
@@ -3600,7 +3600,7 @@ interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelec
36003600
getAttributeNS(namespaceURI: string, localName: string): string;
36013601
getBoundingClientRect(): ClientRect;
36023602
getClientRects(): ClientRectList;
3603-
getElementsByTagName<K extends keyof ElementListTagNameMap>(name: K): ElementListTagNameMap[K];
3603+
getElementsByTagName<K extends keyof ElementTagNameMap>(name: K): NodeListOf<ElementTagNameMap[K]>;
36043604
getElementsByTagName(name: string): NodeListOf<Element>;
36053605
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/1999/xhtml", localName: string): HTMLCollectionOf<HTMLElement>;
36063606
getElementsByTagNameNS(namespaceURI: "http://www.w3.org/2000/svg", localName: string): HTMLCollectionOf<SVGElement>;
@@ -14133,7 +14133,7 @@ interface NavigatorUserMedia {
1413314133
interface NodeSelector {
1413414134
querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null;
1413514135
querySelector<E extends Element = Element>(selectors: string): E | null;
14136-
querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K];
14136+
querySelectorAll<K extends keyof ElementTagNameMap>(selectors: K): NodeListOf<ElementTagNameMap[K]>;
1413714137
querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;
1413814138
}
1413914139

@@ -15026,10 +15026,6 @@ interface SVGElementTagNameMap {
1502615026

1502715027
interface ElementTagNameMap extends HTMLElementTagNameMap, SVGElementTagNameMap { }
1502815028

15029-
type ElementListTagNameMap = {
15030-
[key in keyof ElementTagNameMap]: NodeListOf<ElementTagNameMap[key]>
15031-
};
15032-
1503315029
declare var Audio: { new(src?: string): HTMLAudioElement; };
1503415030
declare var Image: { new(width?: number, height?: number): HTMLImageElement; };
1503515031
declare var Option: { new(text?: string, value?: string, defaultSelected?: boolean, selected?: boolean): HTMLOptionElement; };

0 commit comments

Comments
 (0)