This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Change variants folder T-Beam (espressif#4496) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meehow
changed the title
This was referenced Mar 25, 2021
|
ooh @meehow OOOH that sounds great. Just question though - as your were fixing did you figure out why this change was needed now? (i.e. it has been this way for a long time - so I'm puzzled as to why the build is suddently failing now) |
|
fix for meshtastic/firmware#753 (just to keep github crosslinking) |
|
Author of the commit pointed to espressif@914a50f , but I dodn't dive into this topic, just wanted to compile it and noticed that this simple change can fix the build. It's bit weird because 914a50f is not included to meshtastic master branch. |
|
hmm thanks - yeah I'm puzzled also but your fix is right ;-) |
|
also someday we really neeed to update wrt master again ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.