Backport PR pandas-dev#44144: CI: Fix mypy failures (pandas-dev#44149)

Co-authored-by: Ali McMaster <[email protected]>

Author: meeseeksmachine

pandas/core/dtypes/cast.py

@@ -908,9 +908,9 @@ def maybe_upcast(
     """
     new_dtype, fill_value = maybe_promote(values.dtype, fill_value)
     # We get a copy in all cases _except_ (values.dtype == new_dtype and not copy)
-    values = values.astype(new_dtype, copy=copy)
+    upcast_values = values.astype(new_dtype, copy=copy)
 
-    return values, fill_value
+    return upcast_values, fill_value  # type: ignore[return-value]
 
 
 def invalidate_string_dtypes(dtype_set: set[DtypeObj]):

pandas/tests/indexes/test_engines.py

@@ -61,13 +61,7 @@ class TestTimedeltaEngine:
     @pytest.mark.parametrize(
         "scalar",
         [
-            # error: Argument 1 to "Timestamp" has incompatible type "timedelta64";
-            # expected "Union[integer[Any], float, str, date, datetime64]"
-            pd.Timestamp(
-                pd.Timedelta(days=42).asm8.view(
-                    "datetime64[ns]"
-                )  # type: ignore[arg-type]
-            ),
+            pd.Timestamp(pd.Timedelta(days=42).asm8.view("datetime64[ns]")),
             pd.Timedelta(days=42).value,
             pd.Timedelta(days=42).to_pytimedelta(),
             pd.Timedelta(days=42).to_timedelta64(),