Skip to content

Fix issue with replacement of code and state in URL #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix issue with replacement of code and state in URL #963

merged 2 commits into from
Jul 16, 2021

Conversation

kranich
Copy link
Contributor

@kranich kranich commented Oct 27, 2020

Fixes #959

@kranich
Copy link
Contributor Author

kranich commented Oct 27, 2020

@manfredsteyer Could you please have a look at this soon? We are using this library in production and need this to be fixed.

@codeepic
Copy link

codeepic commented Nov 9, 2020

@manfredsteyer - please can you have a look and approve this PR?
We have moved from Okta to ADB2C Identity Provider but none of the JS libraries that are supposed to work with this work for us (MSAL, MSAL Angular, MSAL 2) and we are using this library now - it works in the sample app but not for our production app, the code is not decoded from the url once we pass the authentication.

@kranich kranich mentioned this pull request Mar 8, 2021
Closed
@manfredsteyer manfredsteyer merged commit 5e00358 into manfredsteyer:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid url after authentication
3 participants
@kranich @codeepic @manfredsteyer