Fix SSR ReferenceError with decorator metadata #855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is only needed for JIT support
|
Let's go with your other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
like #853 this PR also solves issue #773. After researching a bit more I found a different solution. Because each solution might have different tradeoffs for you, I will leave both PRs open for now.
I removed the
emitDecoratorMetadataoption, which is only needed for JIT support, if I am not mistaken: angular/angular#30586 (comment). So with Angular 9 it should not be needed.The actual issue seems to be a TypeScript limitation, but I opened issue angular/angular#37472 with the angular team, to check whether this is a regression to a workaround they have implemented. From that issue you can find more information from the Angular team in linked issues that describe the original problem very well.
Thank you!