Skip to content

#260: Improve error handling on missing tokenEndpoint #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2020
Merged

#260: Improve error handling on missing tokenEndpoint #656

merged 2 commits into from
Mar 2, 2020

Conversation

dirkbolte
Copy link
Contributor

Addresses a finding which can cause #260 .

jeroenheijmans
jeroenheijmans reviewed Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@jeroenheijmans jeroenheijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like a good set of changes in essence, just a few (mostly duplicated/repeated) comments on the messages.

(Sorry, I hit "Add single comment" on GitHub instead of bundling them in a review. Hope it didn't spam your inbox too much.)

@dirkbolte
Copy link
Contributor Author

Thanks for the PR! Looks like a good set of changes in essence, just a few (mostly duplicated/repeated) comments on the messages.

(Sorry, I hit "Add single comment" on GitHub instead of bundling them in a review. Hope it didn't spam your inbox too much.)

A little but no worries :-)

@dirkbolte
Copy link
Contributor Author

@manfredsteyer any comments from your side?

@manfredsteyer manfredsteyer merged commit 13c1675 into manfredsteyer:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenheijmans jeroenheijmans jeroenheijmans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkbolte @jeroenheijmans @manfredsteyer