Skip to content

Added popup related error handling for implicit grant #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2020
Merged

Added popup related error handling for implicit grant #647

merged 2 commits into from
Mar 2, 2020

Conversation

dekundu
Copy link

@dekundu dekundu commented Oct 8, 2019

This PR adds code to handle following popup related errors.

  1. Popup closed by end user before authentication is done, i.e., before success redirect url is reached, and tokens have arrived to client
  2. Popup blocked by browser. This is required because any js based attempt to open popup window will be generally blocked by browser. So for such cases end user should be informed accordingly.

@debojitk
Added error handling for blocked popup and closed popup before authen…
dc3c002 
…tication is completed for implicit grant popup authentication
@dekundu dekundu changed the title Added error handling for popup blocked by browser and popup closed by end user before authentication is completed Added popup related error handling for implicit grant Oct 8, 2019
@debojitk
Bug fix:
c0bb15f 
1. Sometimes event handler getting called as soon as the popup is opened, so added a check to see if message actually contains some valid tokens
2. sometime window is also null due to this false event firing, so added check accordingly
@manfredsteyer manfredsteyer merged commit 817fab0 into manfredsteyer:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dekundu @manfredsteyer @debojitk