Upgraded to Angular 8 and cleaned up the project a bit.

[lwensveen]

I'm not done yet, still need to fix lint issues.

Seems to work though, but I didn't really test it yet.

[jeroenheijmans]

Wow, that's... a lot of changes. Hope you've coordinated with the maintainer (or otherwise have done this for yourself as well).

At first glance all changes seem great to me, but seems to be multiple things in one commit (angular upgrade, docs changes and upgrades, reformatting, etc. etc. etc.) making it pretty hard to review (at least for me, personally) or later track where something has went wrong.

[lwensveen]

Yeah sorry, one thing kind of led to another etc etc. I'll take the time tomorrow to fix it properly.

You could check it though, the docs you can sort of skip. I ran it once to check if it still worked, which it did. But when I wanted to remove the dir it told me I removed some files etc etc and I was in a hurry so I didn't really check out what happened there and just left it as it is.

Made the PR so people know someone's working on it.

[lwensveen]

@jeroenheijmans Fixed :)

[lwensveen]

@manfredsteyer @jeroenheijmans

Still interested in this or what? Otherwise I'm going to use my own fork and I'll try to keep it up to date with PR's from your repo.

[jeroenheijmans]

I'm merely an interested member of the community, with no write access to the repository. I try to help figure out issues, and review PRs, just to make the work for Manfred a wee bit easier. But in the end, it's up to him to decide and merge. I presume he's just busy with other things, and going with a fork for a (hopefully short) while is a reasonable option.

[lwensveen]

Tried implementing some PR's, but this oauth-service is so massive and the old PR's are so old that it's missing big parts of said service which makes it hard to fix these issues.

[jeroenheijmans]

It seems we went with the smaller PR in #573. Hoping the outcome (an upgrade to ng8 with this library) makes up a bit. We could ping @manfredsteyer to see if he has anything to add, or whether he'd want to take in parts of your PR in smaller chunks. For now I'm inclined to close this PR as the ng8 upgrade is in the library now. Thx again for all the proactive support though!