Change 'Authentication' to 'Authorization' #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

manfredsteyer merged 2 commits into manfredsteyer:master from jeroenheijmans:fix/basic-auth-header

Sep 19, 2018

Collaborator

jeroenheijmans commented Jul 1, 2018

Change 'Authentication' to 'Authorization'

Fixes #368

jeroenheijmans added 2 commits

July 2, 2018 00:10


          Change 'Authentication' to 'Authorization'

3da25e1

Fixes manfredsteyer#368


          Change "BASIC" to "Basic"

fe5cc59

After further discussion and research in manfredsteyer#368 I noticed that even
though RFC 7617 seems to state that:

> Note that both scheme and parameter names are matched
> case-insensitively.

All the examples use "Basic" instead of "BASIC". There is one very
notable framework that checks case *sensitively* for "Basic". Given
that the header was incorrect anyways, we can be sure that changing
this casing won't further break anything, and work around issues for
server side frameworks like Spring.

See: https://tools.ietf.org/html/rfc7617
See: https://github.com/spring-projects/spring-security/blob/5.0.6.RELEASE/web/src/main/java/org/springframework/security/web/authentication/www/BasicAuthenticationFilter.java#L157

Fixes manfredsteyer#368

manfredsteyer merged commit 0cac039 into manfredsteyer:master

Owner

manfredsteyer commented Sep 19, 2018

Thx

jeroenheijmans deleted the fix/basic-auth-header branch

September 19, 2018 19:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet