Skip to content

Fixed problem with using interceptor with localStorage #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

PiosDamian
Copy link

fixed problem #255


public getStorage(): OAuthStorage {
return this._storage;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better suited as a property?

public get storage() : OAuthStorage {
   return this._storage;
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but setStorage is used as method
that's why i also use it like this

@manfredsteyer
Copy link
Owner

manfredsteyer commented May 9, 2018

Thanks for your effort. I guess your solution could cause cycles:

HttpClient --> Interceptor --> OAuthService
      ^                                  |
      +----------------------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants