Skip to content

Update to new HttpClient #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2017
Merged

Update to new HttpClient #151

merged 3 commits into from
Nov 11, 2017

Conversation

fmalcher
Copy link
Contributor

@fmalcher fmalcher commented Nov 2, 2017

With Angular 5.0.0 released we should finally go with the new HttpClient API.
This PR also brings

  • some interfaces for the HTTP responses
  • updated rollup config
  • some formatting stuff

TODO:
Update and re-generate docs

@fmalcher fmalcher mentioned this pull request Nov 2, 2017
@ima-tech
Copy link

ima-tech commented Nov 7, 2017

Any updates on the merge status for this? Thank you!

@Swissbite
Copy link

@fmalcher Could you also update the angular dependencies so that angular 5 is supported?

@fmalcher
Copy link
Contributor Author

fmalcher commented Nov 8, 2017

@Swissbite What you you (and others) think would be appropriate settings there?

Suggestion:

"peerDependencies": {
    "@angular/core": ">=4.3.0",
    "@angular/common": ">=4.3.0",
    "rxjs": ">=5.1.0",
    "zone.js": ">=0.8.4"
  }

//cc @manfredsteyer

@Swissbite
Copy link

@fmalcher Is it only depending on @angular/core and @angular/common in the angular universe?

Another suggestion to ensure that it will not accidently break with angular 6:

"peerDependencies": {
    "@angular/core": ">=4.3.0 <6.0.0",
    "@angular/common": ">=4.3.0<6.0.0",
    "rxjs": ">=5.1.0",
    "zone.js": ">=0.8.4"
  }

@manfredsteyer manfredsteyer merged commit 2d38a48 into manfredsteyer:master Nov 11, 2017
@manfredsteyer
Copy link
Owner

thx

@Gaiidenn
Copy link

Hi here, thanks for this great update!
Any idea when this patch will be available through NPM ?

@Gaiidenn
Copy link

Ok it's done, ty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants