[Issue #1477] Use provided date for token validation #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttkaae
changed the title
ttkaae
changed the title
ttkaae
changed the title
ttkaae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our company we have some agents that use a custom date and time on their computers, which has caused issues with the token validation. Currently, on the
JwksValidationHandleronangular-oauth2-oidc, it uses the current client date to validate the token despite of the library providing a customDateTimeProvider.In this pr I have made a modification to
JwksValidationHandlerto use the provided datetime on the token validation.I have also separated the
jsrsasignlogic to clean up the code and expose those functions.Hope you'll review it and feel free to add some comments
Fixes Issue #1477