refactor(lib): use defaultInterceptor function instead the DefaultInterceptor Class #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Angular v14, and thanks to the fact that inject function can be call outside an injection context we can create interceptor as a function
As the package don't import the HttpClientModule or provide the HttpClient thanks to provideHttpClient.
Currently, to benefit of the DefaultOAuthInterceptor we must add provideHttpClient(withInterceptorFromDI()).
This looks like a little bit as a "Black Box"
Moreover HttpClientModule is deprecated, that force the user to use provideHttpClient function