fix: #728 #1046
Merged
fix: #728 #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same storage regardless of flow in sample The "smart" way to select a different storage type in the sample was causing issues. Sometimes the `setStorage(localStorage)` call would be made just before the _first_ time someone uses Code Flow which after the redirect causes the app to look in `sessionStorage` for the nonce (which it wont find as the initiation of Code Flow still used the localStorage). This fix changes it to always use the same storage type, which gives more reliable results. (I did consider further tweaking the "smart" way to select the right storage, but it's super hard to predict in which order(s) users will swap between flow types in the sample). See also: manfredsteyer#728 (comment) Fixes manfredsteyer#728
|
Thanks! |
|
we are targeting Angular 11 with production ready on your package version 10.0.3. But suffering in this issue and would like to see if your team can release an minor build on version 10. @manfredsteyer |
|
@zakamaner This PR merely updates the sample, not the library itself. So if you have the same issue, you should also check out your application logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same storage regardless of flow in sample
The "smart" way to select a different storage type in the sample
was causing issues. Sometimes the
setStorage(localStorage)callwould be made just before the first time someone uses Code Flow
which after the redirect causes the app to look in
sessionStoragefor the nonce (which it wont find as the initiation of Code Flow
still used the localStorage).
This fix changes it to always use the same storage type, which gives
more reliable results. (I did consider further tweaking the "smart"
way to select the right storage, but it's super hard to predict in
which order(s) users will swap between flow types in the sample).
See also: #728 (comment)
Fixes #728