Skip to content

code flow does not pass options to error handler #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgatian opened this issue Nov 5, 2020 · 0 comments · Fixed by #973
Closed

code flow does not pass options to error handler #972

cgatian opened this issue Nov 5, 2020 · 0 comments · Fixed by #973
Labels
bug For tagging faulty or unexpected behavior.

Comments

@cgatian
Copy link
Contributor

cgatian commented Nov 5, 2020

Describe the bug
If an error occurs during code flow options passed into tryLogin are not passed to handleLoginError, just an empty object.

angular-oauth2-oidc/projects/lib/src/oauth-service.ts

Line 1646 in 5c5b50a

this.handleLoginError({}, parts);

cgatian pushed a commit to cgatian/angular-oauth2-oidc that referenced this issue Nov 5, 2020
fix: in code flow pass options to error handler
c9a2c55 
Closes manfredsteyer#972
@cgatian cgatian mentioned this issue Nov 5, 2020
Merged
@jeroenheijmans jeroenheijmans added the bug For tagging faulty or unexpected behavior. label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For tagging faulty or unexpected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: in code flow pass options to error handler cgatian/angular-oauth2-oidc
2 participants
@jeroenheijmans @cgatian