Skip to content

Protected vs private type definitions #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdgeier opened this issue Sep 27, 2018 · 2 comments
Closed

Protected vs private type definitions #439

jdgeier opened this issue Sep 27, 2018 · 2 comments
Labels
future-version Will be considered, but for a future version. pr-welcome We'd welcome a PR to solve the issue.

Comments

@jdgeier
Copy link
Contributor

jdgeier commented Sep 27, 2018

I have a few specific implementations where I need to override some of the methods and extend OAuthService. Is there a specific reason why all the properties are private instead of protected? For instance I'd like to override loadJwks or loadDiscoveryDocument without having to copy a lot of the other code. Unfortunately I have some services that use proprietary crap that breaks normal oidc flows. I mean I suppose I could fork the repo and switch them all for myself but I'm mostly just curious what they are private instead of protected?

@manfredsteyer
Copy link
Owner

Good point. Care for a PR?

@manfredsteyer manfredsteyer added pr-welcome We'd welcome a PR to solve the issue. future-version Will be considered, but for a future version. labels Oct 5, 2018
@jdgeier
Copy link
Contributor Author

jdgeier commented Oct 5, 2018

I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future-version Will be considered, but for a future version. pr-welcome We'd welcome a PR to solve the issue.
Projects
None yet
Development

No branches or pull requests

2 participants