Skip to content

Match scala symbols composed of valid punctuation #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2018

Conversation

jpbufe3
Copy link
Contributor

@jpbufe3 jpbufe3 commented Jan 3, 2018

Scala symbols can either be composed of word characters or punctuation characters when using the ' operator. The punctuation characters added in this PR are not the full set allowed by the Scala language, but is the set used elsewhere in this bundle for identifier matching.

Fixes #62

Scala symbols can either be composed of word characters or the following punctuation characters: `\/*&^%#@!~<>|=+-`
Fixed the regex to allow for the punctuation case.
@mads-hartmann
Copy link
Owner

@jpbufe3 Thanks! Sorry for being so slow at responding, I had somehow unwatched the repo 🤦‍♂️

@mads-hartmann mads-hartmann merged commit 4ca419a into mads-hartmann:master Feb 17, 2018
@jpbufe3 jpbufe3 deleted the patch-1 branch February 19, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants