Skip to content

Resolve issue causing second buffer not to get created #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

grafail
Copy link
Contributor

@grafail grafail commented Jan 2, 2025

This is a fix for an issue caused by allocating 2 buffers in a row that seems to cause this error: MemoryError: allocation flags must be the same for both buffers

Reproduction code:

fb1 = display_bus.allocate_framebuffer(sz, lcd_bus.MEMORY_SPIRAM)
fb2 = display_bus.allocate_framebuffer(sz, lcd_bus.MEMORY_SPIRAM)

@kdschlosser kdschlosser merged commit 6318e4c into lvgl-micropython:main Jan 3, 2025
3 checks passed
@kdschlosser
Copy link
Collaborator

Thanks for catching this. I did a rework on the initilization of the bus drivers and I removed the special handling for the RGB bus because it is no longer needed so I changed from using a void * buffer to using memoryviews that are stored in the structure for a bus driver. forgot to set the caps for the buffers.

If you are up for it I am ging to reduce the memory footprint of the bus drivers and I will need someone to test to make sure I didn't muck them up. If you are game for it that is going to be coming up as soon as I fix the issue with the USB-CDC stuff.

@grafail
Copy link
Contributor Author

grafail commented Jan 3, 2025

To be honest I have still not been able to get my display set up using micropython, but would be up for testing this.

@kdschlosser
Copy link
Collaborator

well give me the low down on what is going on with it...

@grafail
Copy link
Contributor Author

grafail commented Jan 3, 2025

well give me the low down on what is going on with it...
Added some more context here
#230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants