Skip to content

Search performance optimization #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2021
Merged

Search performance optimization #179

merged 2 commits into from
Sep 12, 2021

Conversation

FishermanZzhang
Copy link
Contributor

@FishermanZzhang FishermanZzhang commented Sep 9, 2021 •
edited
Loading

We made the following changes:

  1. Use raw pointers instead of weak_ptr
  2. The shared_ptr is used as memory management, and the raw pointer is used as the real worker
  3. Optimized unreasonable function calls
  4. parameter references
  5. Simple functions are inlined
  6. Overwrite BufferedIndexInput::readVInt()

#178

@alanw PTAL

@FishermanZzhang
opt call func
ac4abb3 
weakptr 2 raw pointer

move shared_ptr

move shared_ptr

weak_ptr 2 raw pointer

shared_ptr 2 raw pointer

ref, space for time

shared_ptr 2 raw pointer

opt query

opt query

fix bug: set freq value
alanw
alanw reviewed Sep 11, 2021
View reviewed changes
Copy link
Collaborator

@alanw alanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, thank you so much for taking the time to improve performance!

I've left a few comments around removing comment-out code, but I think it looks good

@alanw alanw merged commit 98e87c3 into luceneplusplus:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanw alanw alanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FishermanZzhang @alanw