Skip to content

LIKE -> ILIKE #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

LIKE -> ILIKE #79

wants to merge 2 commits into from

Conversation

rus0000
Copy link

@rus0000 rus0000 commented May 17, 2015

"ILIKE" case-insensitive, and more suitable for autocomplete comboboxes
http://www.postgresql.org/docs/9.4/static/functions-matching.html

@slnode
Copy link

slnode commented May 17, 2015

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@bajtos
Copy link
Member

bajtos commented May 25, 2015

Hi @rus0000, thank you for the pull request. In my opinion, this is a breaking change that also introduces inconsistency with the behaviour of other connectors (e.g. memory connector). I think it would be better to introduce a new operator instead. We already have like and nlike, so it should be relatively straightforward to implement ilike too.

Having said that, I'll let @raymondfeng review this patch as he is more familiar with the code base.

@bajtos
Copy link
Member

bajtos commented May 25, 2015

@slnode ok to test

@rus0000
Copy link
Author

rus0000 commented Jun 19, 2015

See #93

@slnode
Copy link

slnode commented Jun 19, 2015

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants