Skip to content

[wip] native JSON support #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aol-nnov
Copy link
Contributor

@aol-nnov aol-nnov commented Feb 9, 2015

Hi!

I was i need of JSON data type power which PostgreSQL provides, so I've started working in this direction.
It seems, that there is a demand for that support already: #31, #7, so, @gebrits, @kesavkolla I invite you to collaborate in this area if you still interested.

@raymondfeng what do you think about enabling certain features in the connector (upsert support, json, whatever) based on the database version? Where in the code is the best way to test the DB version and fill a set of supported features? Should it be done automatically or set via config? Also tell me please what do you think about mods in this PR?

@aol-nnov
Copy link
Contributor Author

aol-nnov commented Feb 9, 2015

@kesavkolla
Copy link
Contributor

Actually my example is bad. The escapeName doesn't even do anything with select columns. The escapeName is only called from createTable and columns to be dropped. So there is no need to touch that code in my opinion.

@jmls
Copy link

jmls commented Nov 9, 2015

did this stall here ? It would be useful to have the 9.4 json datatypes in place now

@aol-nnov
Copy link
Contributor Author

aol-nnov commented Nov 9, 2015

@jmls sad to say, I've dropped it completely. Moved away from loopback and using bookshelf.js currently.

@jmls
Copy link

jmls commented Nov 9, 2015

@aol-nnov : That's not good to hear. May I ask why ?

@aol-nnov
Copy link
Contributor Author

aol-nnov commented Nov 9, 2015

@jmls well, it was a long way to go :)
first of all, I had to wrap my head around all the guts loopback have. And the best way was to start something similar from scratch, lol.
secondly, I needed better postgresql support, and, to be frank, I really love bookshelf and knex.
and my app is not only api, but a web frontend too (well, it actually does not count as an argument and I could build web frontend atop of loopback)

@ZepAviator
Copy link

Having JSON / JSONb support would be great. It seems that maybe some ideas for code on these properties types could be pulled from the nosql connectors?

Anyone have any branches of working JSON type?

@stale
Copy link

stale bot commented Aug 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@slnode
Copy link

slnode commented Aug 22, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link

slnode commented Aug 22, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Aug 22, 2017

Can one of the admins verify this patch?

@stale stale bot removed the stale label Aug 22, 2017
@stale
Copy link

stale bot commented Oct 21, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 21, 2017
@stale
Copy link

stale bot commented Nov 4, 2017

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this Nov 4, 2017
@zbarbuto
Copy link
Contributor

zbarbuto commented Nov 4, 2017

FWIW #304 was merged recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.