Add test for transaction support in count() #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
requested review from
b-admike,
dhmlau,
jannyHou,
kjdelisle,
loay,
ssh24 and
virkt25
as code owners
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@slnode test please |
|
@lehni I've landed loopbackio/loopback-connector#114, so I'll re-run the tests shortly. |
|
@slnode test please |
jannyHou
approved these changes
Aug 23, 2017
dhmlau
approved these changes
Aug 24, 2017
ssh24
approved these changes
Aug 24, 2017
|
@kjdelisle what's the next step in this PR? |
kjdelisle
approved these changes
Sep 8, 2017
|
@lehni Sorry, there's a lot of stuff going on around here these last few weeks, lots of context switching and I get notifications for everything in the strongloop org. :P I'm landing this right now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As outlined in loopbackio/loopback-connector#114: When passing on a transaction object to connector.count(), it does not currently get passed on internally to the SQL
execute()method, meaning that the count of the table outside the transaction will be counted and a wrong result will be returned.Related issues
Checklist
guide