Fix the escape char #235
Merged
Fix the escape char #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
reviewed
Mar 31, 2017
lib/postgresql.js
Outdated
| @@ -387,13 +387,13 @@ PostgreSQL.prototype.buildExpression = function(columnName, operator, | |||
| return new ParameterizedSQL(columnName + " LIKE ? ESCAPE E'\\\\'", | |||
| [operatorValue]); | |||
| case 'ilike': | |||
| return new ParameterizedSQL(columnName + " ILIKE ? ESCAPE '\\'", | |||
| return new ParameterizedSQL(columnName + " ILIKE ? ESCAPE '\\\\'", | |||
There was a problem hiding this comment.
" LIKE ? ESCAPE E'\\\\'" the case above has an extra E before 4 back-slash, should it be added here as well? The change LGTM while CI fails a lot.
And the transaction test fails due to 2876a95
we can fix that test case in this pr.
There was a problem hiding this comment.
Added E to make it consistent
raymondfeng
force-pushed
the
feature/fix-ilike-escape
branch
from
bd62d4e to
59b1c10
Compare
kjdelisle
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current code fails the tests due to invalid escape chars.
Related issues
Checklist
guide