Skip to content

Update test information in readme #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2017
Merged

Update test information in readme #214

merged 1 commit into from
Feb 17, 2017

Conversation

zbarbuto
Copy link
Contributor

Description

As mentioned in #197 the README information for testing is out of date. This adds brief instructions for how to run tests locally.

cc @jannyHou @crandmck @superkhau

@slnode
Copy link

slnode commented Feb 16, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Feb 16, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link

slnode commented Feb 16, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Feb 16, 2017

Can one of the admins verify this patch?

@zbarbuto zbarbuto mentioned this pull request Feb 16, 2017
Merged
2 tasks
@superkhau
Copy link
Contributor

@rmg CI seems to be hanging, PTAL?

@ssh24
Copy link
Contributor

ssh24 commented Feb 17, 2017

@slnode test please

ssh24
ssh24 reviewed Feb 17, 2017
View reviewed changes
Copy link
Contributor

@ssh24 ssh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbarbuto Thanks for the PR. We just recently updated the README with similar information. I would like to still keep your information as it gives the user another way to run the test directly using the env variables. I will update your branch with another commit

@ssh24
Copy link
Contributor

ssh24 commented Feb 17, 2017

@zbarbuto Could you please rebase your branch?

@ssh24 ssh24 self-assigned this Feb 17, 2017
@ssh24
Copy link
Contributor

ssh24 commented Feb 17, 2017

@slnode test please

ssh24
ssh24 approved these changes Feb 17, 2017
View reviewed changes
Copy link
Contributor

@ssh24 ssh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the PR is rebased, it can be landed.

@ssh24 ssh24 requested a review from dhmlau February 17, 2017 19:02
@crandmck
Copy link
Contributor

LGTM

@ssh24 ssh24 assigned dhmlau and unassigned ssh24 Feb 17, 2017
dhmlau
dhmlau reviewed Feb 17, 2017
View reviewed changes
README.md Outdated
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked my command again. Should be:
\i c:/somepath/test/schema.sql

@ssh24 ssh24 force-pushed the update-test-readme branch 3 times, most recently from 88a550d to ea5ba31 Compare February 17, 2017 20:17
dhmlau
dhmlau approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssh24 ssh24 self-assigned this Feb 17, 2017
@ssh24 ssh24 force-pushed the update-test-readme branch from 3b80dbd to 23b98ed Compare February 17, 2017 21:03
@zbarbuto
Copy link
Contributor Author

All done. Thanks guys.

@ssh24
Copy link
Contributor

ssh24 commented Feb 17, 2017

@slnode test please

@dhmlau dhmlau merged commit 3295dc2 into loopbackio:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superkhau superkhau superkhau approved these changes

@ssh24 ssh24 ssh24 approved these changes

@dhmlau dhmlau dhmlau approved these changes

Assignees

@ssh24 ssh24

@dhmlau dhmlau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zbarbuto @slnode @superkhau @ssh24 @crandmck @dhmlau